Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow deployment of zipkin-gcp collector #29

Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat: allow deployment of zipkin-gcp collector #29

merged 1 commit into from
Jan 2, 2025
+7 −1

Conversation

rolandkool
Copy link
Contributor

The schema update allows this helm chart to be used to deploy the zipkin-gcp collector.

codefromthecrypt
codefromthecrypt approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, though in practice this needs an image override to work

@codefromthecrypt
Copy link
Member

I know this is annoying and you didn't cause it, but if you can fix this newline in this PR, easy to tell if all is ok (which should be)

charts/zipkin/ci/extraManifests-values.yaml

13:20 [new-line-at-end-of-file] no new line character at the end of file

@codefromthecrypt codefromthecrypt merged commit d47269b into openzipkin:master Jan 2, 2025
1 check failed
@codefromthecrypt
Copy link
Member

thanks. let us know if something else ends up needed here

@rolandkool
Copy link
Contributor Author

agreed, though in practice this needs an image override to work

Correct, I use the image.tag and image.repository to override the image to use the zipkin-gcp one.

Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandkool @codefromthecrypt